Autoscale VM load balancing rules code improvements by sureshanaparti · Pull Request #12446 · apache/cloudstack

sureshanaparti · 2026-01-16T06:22:15Z

Description

This PR improves the code for Autoscale VM load balancing rules.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-01-16T06:30:13Z

Codecov Report

❌ Patch coverage is 8.69565% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (5c1f931) to head (4b31782).
⚠️ Report is 2 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...loud/network/lb/LoadBalancingRulesManagerImpl.java	5.61%	82 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #12446   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
  Complexity    13380    13380           
=========================================
  Files          5657     5657           
  Lines        498996   499007   +11     
  Branches      60566    60560    -6     
=========================================
+ Hits          81011    81025   +14     
+ Misses       408951   408946    -5     
- Partials       9034     9036    +2

Flag	Coverage Δ
uitests	`4.03% <ø> (ø)`
unittests	`17.09% <8.69%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2026-01-16T06:34:01Z

@blueorangutan package

blueorangutan · 2026-01-16T06:34:34Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

This PR performs code cleanup and improvements for the Autoscale VM load balancing rules implementation. The changes focus on improving code readability and maintainability through better naming conventions, use of modern Java syntax, and code simplification.

Changes:

Renamed DAO field variables to follow proper camelCase naming conventions (_lb2stickinesspoliciesDao → _lb2StickinessPoliciesDao, _lb2healthcheckDao → _lb2HealthCheckDao)
Modernized code by using diamond operators for generic type inference and simplifying conditional logic
Fixed spelling errors in code comments ("comparisions" → "comparison", "assoication" → "association")
Improved variable naming for better readability (e.g., priIp → primaryIp, lstVmId → vmIds, maps → lb2VmMaps)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java	Renamed DAO fields to proper camelCase, applied diamond operators, improved variable naming, fixed spelling in comments, simplified conditional logic
server/src/test/java/com/cloud/network/lb/UpdateLoadBalancerTest.java	Updated test mock setup to reflect renamed DAO fields
server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java	Improved variable naming from `lstVmId` to `vmIds` and applied diamond operator
engine/schema/src/main/java/com/cloud/network/dao/LoadBalancerVMMapDao.java	Added blank line for better code formatting
engine/schema/src/main/java/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java	Removed extra blank line for cleaner code formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T07:14:39Z

server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java

+                            _lb2VmMapDao.remove(lb.getId(), lbVmMapToRevoke.getInstanceId(), lbVmMapToRevoke.getInstanceIp(), null);
                            logger.debug("Load balancer rule {} is removed for Instance {} and IP {}",
-                                    lb, lbVmMap.getInstanceId(), lbVmMap.getInstanceIp());;
+                                    lb, lbVmMapToRevoke.getInstanceId(), lbVmMapToRevoke.getInstanceIp());;


Double semicolon at the end of the statement. Remove one semicolon.

Suggested change

lb, lbVmMapToRevoke.getInstanceId(), lbVmMapToRevoke.getInstanceIp());;

lb, lbVmMapToRevoke.getInstanceId(), lbVmMapToRevoke.getInstanceIp());

Copilot · 2026-01-16T07:14:40Z

server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java

            }
        }
-        lstVmId.add(new Long(vmId));
+        vmIds.add(new Long(vmId));


The explicit Long constructor call is unnecessary and deprecated. Use Long.valueOf(vmId) or simply add vmId directly since autoboxing will handle the conversion.

Suggested change

vmIds.add(new Long(vmId));

vmIds.add(vmId);

Copilot · 2026-01-16T07:14:40Z

server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java

                        continue;
                    }
-                    if(_nicSecondaryIpDao.findByIp4AddressAndNicId(ip,nicInSameNetwork.getId()) == null) {
+                    if (_nicSecondaryIpDao.findByIp4AddressAndNicId(ip,nicInSameNetwork.getId()) == null) {


Missing space after comma in method call arguments. Add space after the comma for better readability.

Suggested change

if (_nicSecondaryIpDao.findByIp4AddressAndNicId(ip,nicInSameNetwork.getId()) == null) {

if (_nicSecondaryIpDao.findByIp4AddressAndNicId(ip, nicInSameNetwork.getId()) == null) {

Copilot · 2026-01-16T07:14:40Z

server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java

                        map.setRevoke(true);
                        _lb2VmMapDao.persist(map);
-                        logger.debug("Set load balancer rule for revoke: rule {}, vmId {}, vmip {}", loadBalancer::toString, () -> _vmDao.findById(instanceId), vmIp::toString);
+                        logger.debug("Set load balancer rule for revoke: rule {}, vmId {}, vmIp {}", loadBalancer::toString, () -> _vmDao.findById(instanceId), vmIp::toString);


Redundant call to 'toString' on a String object.

Suggested change

logger.debug("Set load balancer rule for revoke: rule {}, vmId {}, vmIp {}", loadBalancer::toString, () -> _vmDao.findById(instanceId), vmIp::toString);

logger.debug("Set load balancer rule for revoke: rule {}, vmId {}, vmIp {}", loadBalancer::toString, () -> _vmDao.findById(instanceId), vmIp);

blueorangutan · 2026-01-16T07:28:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16392

DaanHoogland

co-pilots nitpicking seems to the point but clgtm!

Autoscale VM load balancing rules improvements

4b31782

boring-cyborg bot added the component:networking label Jan 16, 2026

sureshanaparti mentioned this pull request Jan 16, 2026

Autoscale Load Balancing Rule looses VMs during a node failure. #9145

Open

sureshanaparti added the component:autoscale label Jan 16, 2026

sureshanaparti requested a review from Copilot January 16, 2026 07:04

Copilot started reviewing on behalf of sureshanaparti January 16, 2026 07:05 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

sureshanaparti marked this pull request as draft January 16, 2026 08:32

DaanHoogland approved these changes Jan 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autoscale VM load balancing rules code improvements#12446

Autoscale VM load balancing rules code improvements#12446
sureshanaparti wants to merge 1 commit intoapache:4.20from
shapeblue:autoscale-vm-load-balancing-rules-improvements

sureshanaparti commented Jan 16, 2026

Uh oh!

codecov bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

sureshanaparti commented Jan 16, 2026

Uh oh!

blueorangutan commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

blueorangutan commented Jan 16, 2026

Uh oh!

DaanHoogland left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	lb, lbVmMapToRevoke.getInstanceId(), lbVmMapToRevoke.getInstanceIp());;
	lb, lbVmMapToRevoke.getInstanceId(), lbVmMapToRevoke.getInstanceIp());

	if (_nicSecondaryIpDao.findByIp4AddressAndNicId(ip,nicInSameNetwork.getId()) == null) {
	if (_nicSecondaryIpDao.findByIp4AddressAndNicId(ip, nicInSameNetwork.getId()) == null) {

	logger.debug("Set load balancer rule for revoke: rule {}, vmId {}, vmIp {}", loadBalancer::toString, () -> _vmDao.findById(instanceId), vmIp::toString);
	logger.debug("Set load balancer rule for revoke: rule {}, vmId {}, vmIp {}", loadBalancer::toString, () -> _vmDao.findById(instanceId), vmIp);

Conversation

sureshanaparti commented Jan 16, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Jan 16, 2026

Uh oh!

blueorangutan commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 16, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 16, 2026 •

edited

Loading